Skip to content

Conversation

@bhalsey
Copy link
Contributor

@bhalsey bhalsey commented Apr 22, 2025

Issue:

Problem:

Previous PR that sorted domain objects introduced extraneous imports (using) in the netcore client. This is from the sorting that was also added to the buildDomain() function. Turns out the sorting in buildClient() is the only one needed to make the go client and typescript client generation stable.

Solution:

Remove the extraneous sorting that introduces issues. Added comment about clobbering that happens with type to package name mapping.

Linked PR:

Reviewer Notes:

The netcore client generation freemarker has a fair bit of handcrafted logic in it to work. Perhaps this can be refactored, but I didn't want to go down this rabbit hole. Part of the issue is that we reuse names for static inner classes like LambdaConfiguration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants