undo sorting in buildDomain() #5
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Problem:
Previous PR that sorted domain objects introduced extraneous imports (
using) in the netcore client. This is from the sorting that was also added to thebuildDomain()function. Turns out the sorting inbuildClient()is the only one needed to make the go client and typescript client generation stable.Solution:
Remove the extraneous sorting that introduces issues. Added comment about clobbering that happens with type to package name mapping.
Linked PR:
Reviewer Notes:
The netcore client generation freemarker has a fair bit of handcrafted logic in it to work. Perhaps this can be refactored, but I didn't want to go down this rabbit hole. Part of the issue is that we reuse names for static inner classes like
LambdaConfiguration