Skip to content

[Fix]: generator node connectored to batch node #9453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dunkeroni wants to merge 2 commits into
base: main
Choose a base branch
from
+30 −6
Open

[Fix]: generator node connectored to batch node #9453

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9492584
resolve out connector nodes on batch calc
dunkeroni Aug 3, 2026
f64175a
Merge branch 'main' into fix_generator_connectored_to_batch
JPPhoto Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 30 additions & 6 deletions invokeai/frontend/web/src/features/nodes/util/node/resolveBatchValue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import type { AppDispatch } from 'app/store/store';
import type { NodesState } from 'features/nodes/store/types';
import { resolveConnectorSource } from 'features/nodes/store/util/connectorTopology';
import type { ImageField } from 'features/nodes/types/common';
import {
isFloatFieldCollectionInputInstance,
Expand All @@ -15,10 +16,33 @@ import {
resolveIntegerGeneratorField,
resolveStringGeneratorField,
} from 'features/nodes/types/field';
import type { InvocationNode } from 'features/nodes/types/invocation';
import { isBatchNode, isInvocationNode } from 'features/nodes/types/invocation';
import type { AnyEdge, AnyNode, InvocationNode } from 'features/nodes/types/invocation';
import { isBatchNode, isConnectorNode, isInvocationNode } from 'features/nodes/types/invocation';
import { assert } from 'tsafe';

const findGeneratorNode = (
edge: AnyEdge,
nodes: AnyNode[],
edges: AnyEdge[],
invocationNodes: InvocationNode[]
): InvocationNode | undefined => {
const sourceNode = nodes.find((node) => node.id === edge.source);
if (!sourceNode) {
return undefined;
}
if (isInvocationNode(sourceNode)) {
return invocationNodes.find((node) => node.id === sourceNode.id);
}
if (isConnectorNode(sourceNode)) {
const resolvedSource = resolveConnectorSource(sourceNode.id, nodes, edges);
if (!resolvedSource) {
return undefined;
}
return invocationNodes.find((node) => node.id === resolvedSource.nodeId);
}
return undefined;
};

export const resolveBatchValue = async (arg: {
dispatch: AppDispatch;
nodesState: NodesState;
Expand All @@ -37,7 +61,7 @@ export const resolveBatchValue = async (arg: {
return ownValue ?? [];
}

const generatorNode = invocationNodes.find((node) => node.id === incomers.source);
const generatorNode = findGeneratorNode(incomers, nodes, edges, invocationNodes);
assert(generatorNode, 'Missing edge from image generator to image batch');

const generatorField = generatorNode.data.inputs['generator'];
Expand All @@ -54,7 +78,7 @@ export const resolveBatchValue = async (arg: {
return ownValue ?? [];
}

const generatorNode = invocationNodes.find((node) => node.id === edgeToStrings.source);
const generatorNode = findGeneratorNode(edgeToStrings, nodes, edges, invocationNodes);
assert(generatorNode, 'Missing edge from string generator to string batch');

const generatorField = generatorNode.data.inputs['generator'];
Expand All @@ -71,7 +95,7 @@ export const resolveBatchValue = async (arg: {
return ownValue ?? [];
}

const generatorNode = invocationNodes.find((node) => node.id === edgeToFloats.source);
const generatorNode = findGeneratorNode(edgeToFloats, nodes, edges, invocationNodes);
assert(generatorNode, 'Missing edge from float generator to float batch');

const generatorField = generatorNode.data.inputs['generator'];
Expand All @@ -88,7 +112,7 @@ export const resolveBatchValue = async (arg: {
return ownValue ?? [];
}

const generatorNode = invocationNodes.find((node) => node.id === incomers.source);
const generatorNode = findGeneratorNode(incomers, nodes, edges, invocationNodes);
assert(generatorNode, 'Missing edge from integer generator to integer batch');

const generatorField = generatorNode.data.inputs['generator'];
Expand Down
Loading