fix(canvas): restore eyedropper hotkey after tool changes - #9482
Open
DustyShoe wants to merge 2 commits into
Open
fix(canvas): restore eyedropper hotkey after tool changes#9482DustyShoe wants to merge 2 commits into
DustyShoe wants to merge 2 commits into
Conversation
DustyShoe
force-pushed
the
agent/fix-color-picker-hotkey
branch
from
August 9, 2026 12:40
b7eb0f8 to
1936a24
Compare
DustyShoe
changed the title
DustyShoe
marked this pull request as ready for review
August 9, 2026 12:50
DustyShoe
requested review from
JPPhoto,
Pfannkuchensack,
blessedcoolant,
dunkeroni and
lstein
as code owners
August 9, 2026 12:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ito select the eyedropper again after switching to another canvas toolRoot cause
The hotkey registration was dynamically disabled while the eyedropper was selected. After the first activation, the registration did not reliably become active again when another tool was selected.
Validation
pnpm vitest run src/features/controlLayers/konva/CanvasTool/toolHotkeys.test.ts(17 tests passed)I-> other tool ->Icycles without reloading the UIFixes #9467