ci: separate native builds into Android and iOS#129
Open
OS-pedrogustavobilro wants to merge 4 commits into
Open
ci: separate native builds into Android and iOS#129OS-pedrogustavobilro wants to merge 4 commits into
OS-pedrogustavobilro wants to merge 4 commits into
Conversation
OS-pedrogustavobilro
requested review from
a team and
alexgerardojacinto
and removed request for
a team
July 17, 2026 16:16
OS-pedrogustavobilro
marked this pull request as ready for review
July 17, 2026 16:55
| - name: 'Build Web example app' | ||
| working-directory: ./example-app | ||
| shell: bash | ||
| run: pnpm run build |
Member
There was a problem hiding this comment.
I don't think building the plugin and the example app is needed here, build-example-app needs verify-plugin, which needs build-packages, which builds the plugin and both example apps, so they should be built at this point.
And BTW, should we sync/build the example-app-spm too?
I don't think we are doing it in other plugins which has two example apps, but what's the point of having the spm variant if we are not doing anything with it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be in accordance to other capacitor plugin repositories we have.