Skip to content

fix(ios): Adjust WebView sizing during keyboard size changes #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GabrielNSD wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ios): Adjust WebView sizing during keyboard size changes #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
126 changes: 119 additions & 7 deletions ios/Sources/KeyboardPlugin/Keyboard.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ @interface KeyboardPlugin () <UIScrollViewDelegate>
@property (nonatomic, readwrite) ResizePolicy keyboardResizes;
@property (readwrite, assign, nonatomic) NSString* keyboardStyle;
@property (nonatomic, readwrite) int paddingBottom;
@property (nonatomic) NSTimeInterval lastFullDismissalTime;

@end

Expand Down Expand Up @@ -92,6 +93,8 @@ - (void)load
[nc addObserver:self selector:@selector(onKeyboardDidShow:) name:UIKeyboardDidShowNotification object:nil];
[nc addObserver:self selector:@selector(onKeyboardWillHide:) name:UIKeyboardWillHideNotification object:nil];
[nc addObserver:self selector:@selector(onKeyboardWillShow:) name:UIKeyboardWillShowNotification object:nil];
[nc addObserver:self selector:@selector(onKeyboardWillChangeFrame:) name:UIKeyboardWillChangeFrameNotification object:nil];
[nc addObserver:self selector:@selector(onKeyboardDidChangeFrame:) name:UIKeyboardDidChangeFrameNotification object:nil];

[nc removeObserver:self.webView name:UIKeyboardWillHideNotification object:nil];
[nc removeObserver:self.webView name:UIKeyboardWillShowNotification object:nil];
Expand Down Expand Up @@ -129,17 +132,27 @@ - (void)onKeyboardWillShow:(NSNotification *)notification
double height = rect.size.height;

if ([[UIDevice currentDevice] userInterfaceIdiom] == UIUserInterfaceIdiomPad) {
if (stageManagerOffset > 0) {
height = stageManagerOffset;
} else {
CGRect webViewAbsolute = [self.webView convertRect:self.webView.frame toCoordinateSpace:self.webView.window.screen.coordinateSpace];
height = (webViewAbsolute.size.height + webViewAbsolute.origin.y) - (UIScreen.mainScreen.bounds.size.height - rect.size.height);
CGFloat screenHeight = UIScreen.mainScreen.bounds.size.height;
CGFloat keyboardTop = CGRectGetMinY(rect);
CGFloat keyboardBottom = CGRectGetMaxY(rect);
CGFloat keyboardFrameHeight = rect.size.height;

// Check if this is a full keyboard or just accessory bar
// Full keyboard is typically > 250px, accessory bar is < 200px
if (keyboardFrameHeight > 200) {
// Full keyboard - calculate from screen position
// This handles Stage Manager and different window positions correctly
height = screenHeight - keyboardTop;
} else {
// Accessory bar only - use the actual frame height
height = keyboardFrameHeight;
}
NSLog(@"KeyboardPlugin: onKeyboardWillShow - iPad mode, keyboardTop=%.1f, keyboardBottom=%.1f, keyboardFrameHeight=%.1f, screenHeight=%.1f, calculated height=%.1f", keyboardTop, keyboardBottom, keyboardFrameHeight, screenHeight, height);

if (height < 0) {
height = 0;
}

stageManagerOffset = height;
}
}

double duration = [[notification.userInfo valueForKey:UIKeyboardAnimationDurationUserInfoKey] doubleValue]+0.2;
Expand All @@ -156,6 +169,23 @@ - (void)onKeyboardDidShow:(NSNotification *)notification
{
CGRect rect = [[notification.userInfo valueForKey:UIKeyboardFrameEndUserInfoKey] CGRectValue];
double height = rect.size.height;

if ([[UIDevice currentDevice] userInterfaceIdiom] == UIUserInterfaceIdiomPad) {
CGFloat screenHeight = UIScreen.mainScreen.bounds.size.height;
CGFloat keyboardTop = CGRectGetMinY(rect);
CGFloat keyboardFrameHeight = rect.size.height;


if (keyboardFrameHeight > 200) {
height = screenHeight - keyboardTop;
} else {
height = keyboardFrameHeight;
}

if (height < 0) {
height = 0;
}
}

[self resetScrollView];

Expand All @@ -174,6 +204,87 @@ - (void)onKeyboardDidHide:(NSNotification *)notification
stageManagerOffset = 0;
}

- (void)onKeyboardWillChangeFrame:(NSNotification *)notification
{
CGRect rect = [[notification.userInfo valueForKey:UIKeyboardFrameEndUserInfoKey] CGRectValue];

// Check if keyboard is actually on screen (not moving off-screen)
CGFloat screenHeight = UIScreen.mainScreen.bounds.size.height;
BOOL keyboardOnScreen = CGRectGetMinY(rect) < screenHeight;

CGFloat keyboardTop = CGRectGetMinY(rect);
CGFloat keyboardFrameHeight = rect.size.height;

// Detect full dismissal
if (keyboardTop >= screenHeight) {
self.lastFullDismissalTime = [[NSDate date] timeIntervalSince1970];
}

// Ignore accessory bar if it appears within 0.5s of full dismissal
NSTimeInterval timeSinceFullDismissal = [[NSDate date] timeIntervalSince1970] - self.lastFullDismissalTime;
if (keyboardFrameHeight < 200 && timeSinceFullDismissal < 0.5) {
return;
}


double height = rect.size.height;

if ([[UIDevice currentDevice] userInterfaceIdiom] == UIUserInterfaceIdiomPad) {
CGFloat keyboardTop = CGRectGetMinY(rect);
CGFloat keyboardBottom = CGRectGetMaxY(rect);
CGFloat keyboardFrameHeight = rect.size.height;

// Distinguish between full keyboard and accessory bar by frame height
if (keyboardFrameHeight > 200) {
// Full keyboard - calculate from screen position for Stage Manager support
height = screenHeight - keyboardTop;
} else {
// Accessory bar only - during transitions, iOS reports incorrect sizes
// Skip WillChangeFrame for small keyboards, wait for DidShow with stable value
return;
}

if (height < 0) height = 0;

}

double duration = [[notification.userInfo valueForKey:UIKeyboardAnimationDurationUserInfoKey] doubleValue];
NSLog(@"KeyboardPlugin: onKeyboardWillChangeFrame - setting height=%d with duration=%.2f", (int)height, duration);
[self setKeyboardHeight:height delay:duration];
[self resetScrollView];

NSString *data = [NSString stringWithFormat:@"{ 'keyboardHeight': %d }", (int)height];
[self.bridge triggerWindowJSEventWithEventName:@"keyboardWillChangeFrame" data:data];
NSDictionary *kbData = @{@"keyboardHeight": [NSNumber numberWithDouble:height]};
[self notifyListeners:@"keyboardWillChangeFrame" data:kbData];
}

- (void)onKeyboardDidChangeFrame:(NSNotification *)notification
{
CGRect rect = [[notification.userInfo valueForKey:UIKeyboardFrameEndUserInfoKey] CGRectValue];
double height = rect.size.height;

if ([[UIDevice currentDevice] userInterfaceIdiom] == UIUserInterfaceIdiomPad) {
CGFloat screenHeight = UIScreen.mainScreen.bounds.size.height;
CGFloat keyboardTop = CGRectGetMinY(rect);
CGFloat keyboardFrameHeight = rect.size.height;


if (keyboardFrameHeight > 200) {
height = screenHeight - keyboardTop;
} else {
height = keyboardFrameHeight;
}

if (height < 0) height = 0;
}

NSString *data = [NSString stringWithFormat:@"{ 'keyboardHeight': %d }", (int)height];
[self.bridge triggerWindowJSEventWithEventName:@"keyboardDidChangeFrame" data:data];
NSDictionary *kbData = @{@"keyboardHeight": [NSNumber numberWithDouble:height]};
[self notifyListeners:@"keyboardDidChangeFrame" data:kbData];
}

- (void)setKeyboardHeight:(int)height delay:(NSTimeInterval)delay
{
if (self.paddingBottom == height) {
Expand Down Expand Up @@ -224,6 +335,7 @@ - (void)_updateFrame
if (self.webView != nil) {
wf = self.webView.frame;
}

switch (self.keyboardResizes) {
case ResizeBody:
{
Expand Down