Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Currently, the v9 docs document the Gallery, which only exists on the
nextbranch ofionic-frameworkand is not part of the v9 release. Separately, the component API tables are generated from@ionic/docs@8.8.9-dev.11781201980.1b6e8398, a dev build of anextbranch commit, so every API page reports thenextAPI surface rather than v9's. That build adds 193 properties that do not exist in v9, includingthemeon around 90 components plusshape,size,hue,expand,titlePlacement, andhideOnScroll. It also omitsswipeGestureonion-router-outletandlabelPlacementandjustifyonion-select-option, which are real v9 properties, and still carriesion-picker-legacy, which v9 removed.What is the new behavior?
The Gallery documentation moves to the new
major-10.0branch, so this removesdocs/api/gallery.md,docs/api/gallery-item.md,static/usage/v9/gallery/, andstatic/img/demos/gallery/. Two edits from the original Gallery PRs are reverted along with it: theGridssidebar category and itsdocs/components.mdcard go back toGrid, since the rename was only made to fit the Gallery into that family. The unrelatedInputs providetypo fix from #4484 is kept.The API generation tag now points at
8.8.16-dev.11784913436.1a334b43, built from themajor-9.0branch ofionic-framework. That drops the 193 properties, restores the three v9 properties that were missing, and clears the staleion-picker-legacydata.Does this introduce a breaking change?
Other information
Verified against the generated output that no component reports
theme, thattitlePlacementandhideOnScrollare gone, that no Gallery pages generate, and thatlabelPlacementonion-select-optionis still present. The four remaining broken-link warnings are inversioned_docs/version-v7/index.md, which this branch does not touch.Companion branch: major-10.0, which archives v9 into
versioned_docs/version-v9/and keeps the Gallery as v10 content.When this lands,
major-9.0needs merging intomajor-10.0once, resolving in favour of v10. A plain merge deletesstatic/img/demos/gallery/, drops the Gallery entries fromsidebars.js, and reverts thedocs/components.mdcard without raising a conflict on any of the three, because those hunks only change on this side. Everything else conflicts loudly. Doing that merge once makes this commit an ancestor ofmajor-10.0so later syncs stay clean.Previews: