Skip to content

chore(docs): remove obsolete TODO and placeholder comments #4633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thetaPC wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(docs): remove obsolete TODO and placeholder comments #4633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions docs/api/datetime-button.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,6 @@ import FormatOptions from '@site/static/usage/v8/datetime-button/format-options/

`ion-datetime-button` must be associated with a mounted `ion-datetime` instance. As a result, [Inline Modals](./modal#inline-modals-recommended) and [Inline Popovers](./popover#inline-popovers) with the `keepContentsMounted` property set to `true` must be used.

{/* ## Customization */}
{/* TODO */}
{/* ### Buttons */}
{/* TODO */}
{/* ### Theming */}
{/* TODO */}

## Properties
<Props />

Expand Down
9 changes: 0 additions & 9 deletions docs/api/item.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,15 +178,6 @@ import DetailArrows from '@site/static/usage/v8/item/detail-arrows/index.md';

<DetailArrows />


{/* TODO add this functionality back as a css variable */}
{/* This feature is not enabled by default on clickable items for the `md` mode, but it can be enabled by setting the following CSS variable: */}
{/* ```css */}
{/* --item-detail-push-show: true; */}
{/* ``` */}
{/* See the [theming documentation](/docs/theming/css-variables) for more information. */}


## Item Lines

Items show an inset bottom border by default. The border has padding on the left and does not appear under any content that is slotted in the `"start"` slot. The `lines` property can be modified to `"full"` or `"none"` which will show a full width border or no border, respectively.
Expand Down
2 changes: 0 additions & 2 deletions docs/cli.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ Be sure to run `ionic <command> --help` in your project directory.
For some commands, such as `ionic serve`, the help documentation is contextual to the type of your project, e.g. React vs Angular.
:::

{/* TODO: image? */}

## Architecture

The Ionic CLI is built with [TypeScript](/docs/reference/glossary#typescript) and [Node.js](/docs/reference/glossary#node). It supports Node 10.3+, but the latest Node LTS is always recommended. Follow development on the open source <a href="https://github.com/ionic-team/ionic-cli" target="_blank">GitHub repository</a>.
Expand Down
2 changes: 0 additions & 2 deletions docs/core-concepts/what-are-progressive-web-apps.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ title: Progressive Web Apps
/>
</head>

{/* TOC goes here */}

### The web...but better

A Progressive Web App (PWA) is a web app that uses modern web capabilities to deliver an app-like experience to users.
Expand Down
2 changes: 0 additions & 2 deletions docs/reference/versioning.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# Versioning

{/* TOC goes here */}

Ionic Framework follows the <a href="https://semver.org/" target="_blank">Semantic Versioning (SemVer)</a> convention: <code>major.minor.patch.</code> Incompatible API changes increment the <code>major</code> version, adding backwards-compatible functionality increments the <code>minor</code> version, and backwards-compatible bug fixes increment the <code>patch</code> version.

## Release Schedule
Expand Down
7 changes: 0 additions & 7 deletions versioned_docs/version-v7/api/datetime-button.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,6 @@ import FormatOptions from '@site/static/usage/v7/datetime-button/format-options/

`ion-datetime-button` must be associated with a mounted `ion-datetime` instance. As a result, [Inline Modals](./modal#inline-modals-recommended) and [Inline Popovers](./popover#inline-popovers) with the `keepContentsMounted` property set to `true` must be used.

{/* ## Customization */}
{/* TODO */}
{/* ### Buttons */}
{/* TODO */}
{/* ### Theming */}
{/* TODO */}

## Properties

<Props />
Expand Down
7 changes: 0 additions & 7 deletions versioned_docs/version-v7/api/item.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,13 +292,6 @@ import DetailArrows from '@site/static/usage/v7/item/detail-arrows/index.md';

<DetailArrows />

{/* TODO add this functionality back as a css variable */}
{/* This feature is not enabled by default on clickable items for the `md` mode, but it can be enabled by setting the following CSS variable: */}
{/* ```css */}
{/* --item-detail-push-show: true; */}
{/* ``` */}
{/* See the [theming documentation](/docs/theming/css-variables) for more information. */}

## Item Lines

Items show an inset bottom border by default. The border has padding on the left and does not appear under any content that is slotted in the `"start"` slot. The `lines` property can be modified to `"full"` or `"none"` which will show a full width border or no border, respectively.
Expand Down
2 changes: 0 additions & 2 deletions versioned_docs/version-v7/cli.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ Be sure to run `ionic <command> --help` in your project directory.
For some commands, such as `ionic serve`, the help documentation is contextual to the type of your project, e.g. React vs Angular.
:::

{/* TODO: image? */}

## Architecture

The Ionic CLI is built with [TypeScript](/docs/reference/glossary#typescript) and [Node.js](/docs/reference/glossary#node). It supports Node 10.3+, but the latest Node LTS is always recommended. Follow development on the open source <a href="https://github.com/ionic-team/ionic-cli" target="_blank">GitHub repository</a>.
Expand Down
2 changes: 0 additions & 2 deletions versioned_docs/version-v7/core-concepts/what-are-progressive-web-apps.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ title: Progressive Web Apps
/>
</head>

{/* TOC goes here */}

### The web...but better

A Progressive Web App (PWA) is a web app that uses modern web capabilities to deliver an app-like experience to users.
Expand Down
2 changes: 0 additions & 2 deletions versioned_docs/version-v7/reference/versioning.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# Versioning

{/* TOC goes here */}

Ionic Framework follows the <a href="https://semver.org/" target="_blank">Semantic Versioning (SemVer)</a> convention: <code>major.minor.patch.</code> Incompatible API changes increment the <code>major</code> version, adding backwards-compatible functionality increments the <code>minor</code> version, and backwards-compatible bug fixes increment the <code>patch</code> version.

## Release Schedule
Expand Down