checks: miscellaneous test suite improvements#980
Merged
Conversation
Nixpkgs is now versioning different wasm-bindgen-cli builds so we don't necessarily have to override by pinning hashes
The use case of having a git dependency with a specified branch (but no explicit revision) is already captured by `simple-git`
Can't seem to reproduce this test any more. Wonder if somehow a build script was lost across crate updates, either way the test doesn't seem to be gating much anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This mostly seeks to improve the test suite by reducing the crates needed to compile and combining test workspaces where appropriate
Checklist
docs/API.md(or general documentation) with changesCHANGELOG.md