feat: expose HTTP headers on cmds.Request#332
Draft
lidel wants to merge 1 commit into
Draft
Conversation
Adds Request.Headers (http.Header), populated by the HTTP transport from r.Header.Clone() in parseRequest. Local in-process executor leaves it nil; handlers that read it can rely on http.Header.Get being safe on a nil receiver. Lets command handlers read request-scoped metadata (correlation ids, trace context, feature flags) without each downstream having to maintain custom HTTP middleware to lift headers into context.Context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quality of live improvement, lets command handlers read request-scoped metadata (correlation ids, trace context, feature flags) without each downstream having to maintain custom HTTP middleware to lift headers into context.Context.
This is step towards
EventSourcesupport in Kubo RPC.WIP, do not merge until we have Kubo PR that uses this.