feat: use HelpText.HTTP for Content-Type documentation #2248
+165
−248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates http-api-docs to read Content-Type from the new HelpText.HTTP.ResponseContentType field instead of cmd.Extra. changes: - extract contentType and httpDescription from Helptext.HTTP - add HTTPDescription field to Endpoint struct for future use - show Content-Type without backticks for better readability - improve response text for endpoints with/without Content-Type depends on: - go-ipfs-cmds@0ab930fef0cd (feat: add HTTPHelpText) - kubo@70b7f0736d5b (feat: use HelpText.HTTP for Content-Type)
Contributor
🚀 Build Preview on IPFS ready
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates http-api-docs to read Content-Type from the new HelpText.HTTP.ResponseContentType field to document returned content-type at https://docs.ipfs.tech/reference/kubo/rpc/ when the next Kubo release (0.40) ships.
changes:
depends on: