Skip to content

fix: gofmt -s composite literal simplification in test harness#11260

Closed
Shashwat-Nautiyal wants to merge 1 commit intoipfs:masterfrom
Shashwat-Nautiyal:fix/gofmt-composite-literal-node-go
Closed

fix: gofmt -s composite literal simplification in test harness#11260
Shashwat-Nautiyal wants to merge 1 commit intoipfs:masterfrom
Shashwat-Nautiyal:fix/gofmt-composite-literal-node-go

Conversation

@Shashwat-Nautiyal
Copy link
Copy Markdown

Fixes a gofmt -s issue in the test harness that was causing make test_short to fail.
The change removes a redundant type name in a map composite literal as suggested by gofmt -s.

Changes

  • Simplified composite literal in test/cli/harness/node.go
  • Fixed formatting so that the short test suite passes again

Related Issue

Fixes #11259

Notes

  • This is a pure formatting fix (no functional changes)
  • I have performed a self-review of my own code
  • My code passes make test_short
  • gofmt -s has been applied where needed

@Shashwat-Nautiyal Shashwat-Nautiyal requested a review from a team as a code owner March 29, 2026 08:32
@Shashwat-Nautiyal
Copy link
Copy Markdown
Author

I am not able to add "skip/changelog" label from the sidebar. Idk whether it is a permission issue.

@lidel
Copy link
Copy Markdown
Member

lidel commented Mar 29, 2026

@Shashwat-Nautiyal thank you, but this was already addressed in #11256

(manual changelog check is something reviewer does, it is not possible to skip by design)

@lidel lidel closed this Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: make test_short fails on gofmt -s check in test harness

2 participants