Add a --profile flag to kernel install#165
Merged
Merged
Conversation
added 3 commits
July 28, 2016 19:11
Setting the IPython profile to be used by the kernel.
|
|
||
| def install(kernel_spec_manager=None, user=False, kernel_name=KERNEL_NAME, display_name=None, prefix=None): | ||
| def install(kernel_spec_manager=None, user=False, kernel_name=KERNEL_NAME, display_name=None, | ||
| profile=None, prefix=None): |
Member
There was a problem hiding this comment.
Can you add profile on the end instead of just before prefix, so that it's a backward-compatible patch in the extremely unlikely event of people passing all arguments positionally?
Member
|
Great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E.g.
The idea is to be able to configure the kernel to always use a given IPython profile. This could be pretty useful for creating custom versions of the ipykernel.
I realised that there was already almost support for this in the code, I just added a new argument and hooked it up to the internals.