Skip to content

ensure status is included in all replies#171

Merged
takluyver merged 1 commit into
ipython:masterfrom
minrk:status-ok
Aug 8, 2016
Merged

ensure status is included in all replies#171
takluyver merged 1 commit into
ipython:masterfrom
minrk:status-ok

Conversation

@minrk

@minrk minrk commented Aug 3, 2016

Copy link
Copy Markdown
Member

according to the spec

Comment thread ipykernel/tests/utils.py Outdated
except AttributeError:
stdout = open(os.devnull)
kwargs.update(dict(stdout=stdout, stderr=STDOUT))
# kwargs.update(dict(stdout=stdout, stderr=STDOUT))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgotten debug, or do you want to actively remove it ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, good catch. Fixed.

@Carreau

Carreau commented Aug 5, 2016

Copy link
Copy Markdown
Member

+1 otherwise.

@minrk minrk mentioned this pull request Aug 8, 2016
@takluyver takluyver merged commit c964e61 into ipython:master Aug 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants