fix and test thread local hook registry#188
Conversation
only the main thread initialized hooks correctly,
so other threads would see AttributeError('hooks')
on other threads.
|
Nothing obviously wrong, but I haven't followed this bit of the code closely enough to know exactly how/why we're using thread local data. Do you think it needs more careful review, or are you confident in it? |
|
It's a straightforward bug and test covers it, so I'm pretty confident. |
|
@takluyver thanks! I'll make a release shortly. Since a few 4.5 PRs have been merged, do you have an opinion on making a backport 4.4.2 release stripping these out, or just releasing 4.5? I'll update the milestones to match whatever we end up doing. I'm leaning slightly towards just releasing 4.5, and bumping the remaining issue to 4.6. |
|
I'm fine with making a 4.5 release; it's not really any more effort than doing 4.4.2, is it? Release early, release often, and all that jazz. |
|
Indeed. I'll do 4.5, then. |
|
@takluyver 4.5 changelog in #189, then I'll release. |
2 participants
only the main thread initialized hooks correctly, so other threads would see AttributeError('hooks') on other threads.
closes #180