Disable parent-poller if PID is 1#233
Merged
Merged
Conversation
Parent polling doesn't work for PID 1, the kernel will just exit immediately.
Member
Author
|
appveyor is failing due to something weird with a tornado prerelease. Not related to this PR |
|
someone should write a series of mystery novel titles based on obscure bugs "Jupyterhub and the mystery of the PID killer" |
|
Aaah, I had no idea we had a parent poller (not just a child one). This makes sense! |
|
I've tested this and it seems to fix the issue! |
willingc
reviewed
Mar 28, 2017
| self.poller = ParentPollerWindows(self.interrupt, self.parent_handle) | ||
| elif self.parent_handle: | ||
| elif self.parent_handle and self.parent_handle != 1: | ||
| # PID 1 is special. Parent polling doesn't work if ppid == 1 to start with. |
Member
There was a problem hiding this comment.
Maybe add: # PID 1 (system init process) has no parent. Parent...
Member
Author
|
Thanks! Fixed the appveyor build in #237 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PID 1 is special, and we can't treat it the same as we do in other cases. When run in Docker, the parent (notebook server) can be PID 1, which results in IPython kernels exiting immediately on start, which manifests as "Kernel Restarting..." and "Kernel appears to have died". This is caused by the parent poller incorrectly detecting that the parent has exited, and shutting down.
Also adds logging for parent-exit-triggered shutdown, which would have helped figure this out much quicker.
closes jupyterhub/kubespawner#31
related: cassinyio/SwarmSpawner#6
cc @yuvipanda