Skip to content

inherit IOStream from TextIOBase#234

Merged
minrk merged 1 commit into
ipython:masterfrom
minrk:outstream-textio
Mar 29, 2017
Merged

inherit IOStream from TextIOBase#234
minrk merged 1 commit into
ipython:masterfrom
minrk:outstream-textio

Conversation

@minrk

@minrk minrk commented Mar 27, 2017

Copy link
Copy Markdown
Member

ensures all expected APIs are present and raise appropriate errors for undefined methods, rather than AttributeError.

closes #187

ensures all expected APIs are present
and raise appropriate errors for undefined methods,
rather than AttributeError.
@minrk minrk added this to the 4.6 milestone Mar 27, 2017
@minrk

minrk commented Mar 27, 2017

Copy link
Copy Markdown
Member Author

tornado prerelease has confused pip on appveyor

@minrk minrk mentioned this pull request Mar 28, 2017
4 tasks

@willingc willingc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @minrk. Leaving for you to merge due to Appveyor being confused.

@minrk minrk merged commit 3be349d into ipython:master Mar 29, 2017
@minrk minrk deleted the outstream-textio branch March 29, 2017 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

subclass TextIOBase in OutStream

2 participants