Update version str to be pep 440 compliant, start beta1#341
Merged
Conversation
Carreau
commented
Sep 12, 2018
Carreau
commented
Member
- should we also drop 3.4 in IPykernel 5.0 ?
- Jump version number ot 7.0 to re-sync with IPython ?
minrk
reviewed
Sep 13, 2018
| version_info = (5, 0, 0, 'b1') | ||
| __version__ = '.'.join(map(str, version_info[:3])) | ||
|
|
||
| # pep440 is annoying, beta/alpha/rc should _not_ have dots or pip/setuptools |
Member
There was a problem hiding this comment.
This isn't an issue because we are using setuptools in setup.py. It only comes up in the packages where we skip the setuptools import in setup.py when making an sdist, which we don't do here, and should eventually not do anywhere anymore.
minrk
reviewed
Sep 13, 2018
| 5.0.0 | ||
| ***** | ||
|
|
||
| `4.9.0 on GitHub <https://github.com/ipython/ipykernel/milestones/5.0>`__ |
Member
I don't think so—the whole point of separate packages is that the versions are independent, so they should diverge. If the versions should be kept in sync, then they shouldn't be separate packages. |
minrk
changed the title
Member
|
5.0b1 is tagged and up on PyPI |
Member
Author
|
THanks ! Apologies if I'm a bit slow these days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.