Skip to content

add github actions, bail on asyncio patch for tornado 6.1#564

Merged
blink1073 merged 1 commit into
ipython:masterfrom
bollwyvl:master
Dec 10, 2020
Merged

add github actions, bail on asyncio patch for tornado 6.1#564
blink1073 merged 1 commit into
ipython:masterfrom
bollwyvl:master

Conversation

@bollwyvl

@bollwyvl bollwyvl commented Dec 10, 2020

Copy link
Copy Markdown
Contributor

This PR:

  • removes appveyor and travis
  • adds github actions
    • tests (py3.{6,7,8,9} + pypy) x {win,lin,mac}
      • couldn't even really get 3.5 going, not sure what's up
    • codecov
    • wheel caching
  • adds skips for some osx/pypy tests that just aren't working
    • we already skip them in conda-forge downstream
  • adds a version check for the tornado asyncio patch(es) on windows

Almost any of the excursions can flake, but at least they flake fast and hard instead of locking up until the CI reaps them for timeout.

Links:

@blink1073 blink1073 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@blink1073 blink1073 merged commit b4bf5a2 into ipython:master Dec 10, 2020
@Zsailer

Zsailer commented Dec 10, 2020

Copy link
Copy Markdown
Member

This might warrant a quick patch release here. Things are a bit flaky in jupyter_server's CI and I think it's related to this issue.

@Zsailer

Zsailer commented Dec 10, 2020

Copy link
Copy Markdown
Member

BTW, thank you @bollwyvl!

@bollwyvl

bollwyvl commented Dec 10, 2020 via email

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

handle tornado 6.1 on windows vs python 3.8

4 participants