Open
Conversation
…-metrics for statter
vasilev
reviewed
Jun 14, 2017
| config.GCStats = 1 | ||
| } | ||
| metricsConfig.EnableRuntimeMetrics = true | ||
| metricsConfig.ProfileInterval = time.Duration(config.Interval * float64(time.Second)) |
Contributor
There was a problem hiding this comment.
Maybe time.Duration(config.Interval) * time.Second instead of time.Duration(config.Interval * float64(time.Second)) to omit float64() ?
| @@ -1,139 +1,59 @@ | |||
| // Copyright 2016 Iron.io | |||
Contributor
There was a problem hiding this comment.
It's an open repo, and all other files contain this license info (please refer to #10).
I'd like to retain license info here.
|
|
||
| func (s *MultiStatter) NewTimer(component string, stat string, rate float32) *Timer { | ||
| return newTimer(s, component, stat, rate) | ||
| func AsStatField(input string) string { |
Contributor
There was a problem hiding this comment.
Looks like AsStatField() is not in use anywhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API changed, need to merge PR in iron-io/go to build runner docker image