-
Notifications
You must be signed in to change notification settings - Fork 2
Refactor Makefile and GH workflows
#7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| --- | ||
| name: Bug report 🐞 | ||
| about: Create a report to help us improve | ||
| title: '' | ||
| labels: bug | ||
| assignees: '' | ||
| --- | ||
|
|
||
| **Describe the bug** | ||
| A clear and concise description of what the bug is. | ||
|
|
||
| **To Reproduce** | ||
| Steps to reproduce the behavior e.g. provide example action definition. | ||
|
|
||
| **Expected behavior** | ||
| A clear and concise description of what you expected to happen. | ||
|
|
||
| **Screenshots** | ||
| If applicable, add screenshots to help explain your problem. | ||
|
|
||
| **Additional context** | ||
| Add any other context about the problem here. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| --- | ||
| name: Feature Request 💡 | ||
| about: Suggest a new idea for the project. | ||
| labels: enhancement | ||
| --- | ||
|
|
||
| # Summary | ||
|
|
||
| Brief explanation of the feature. | ||
|
|
||
| ## Basic example | ||
|
|
||
| If the proposal involves a new or changed API, include a basic code example. Omit this section if it's not applicable. | ||
|
|
||
| ## Motivation | ||
|
|
||
| Why are we doing this? What use cases does it support? What is the expected outcome? |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| name: Question ❓ | ||
| about: Is something unclear? | ||
| labels: question | ||
| --- | ||
|
|
||
| # Question? |
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. While I don't have a strong opinion here, Renovate is actually favored in all https://github.com/SAP-cloud-infrastructure / https://github.com/sapcc so let's decide on this in a bigger round.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Me neither. We haven't enabled/used renovate in the ironcore-dev org yet. I guess in the POC state of the project this part is not really a show stopper and can be fixed later. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| --- | ||
| version: 2 | ||
| updates: | ||
| - package-ecosystem: "gomod" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "weekly" | ||
| # Ignore K8 packages as these are done manually | ||
| ignore: | ||
| - dependency-name: "k8s.io/api" | ||
| - dependency-name: "k8s.io/apiextensions-apiserver" | ||
| - dependency-name: "k8s.io/apimachinery" | ||
| - dependency-name: "k8s.io/apiserver" | ||
| - dependency-name: "k8s.io/client-go" | ||
| - dependency-name: "k8s.io/component-base" | ||
| - dependency-name: "k8s.io/kube-aggregator" | ||
| - dependency-name: "k8s.io/kubectl" | ||
| - dependency-name: "sigs.k8s.io/controller-runtime" | ||
| - package-ecosystem: "github-actions" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "weekly" | ||
| - package-ecosystem: "docker" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "weekly" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # Proposed Changes | ||
|
|
||
| - | ||
| - | ||
| - | ||
|
|
||
| Fixes # |
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Any reason to not go with https://goreleaser.com?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just to provide some background, why imo GoReleaser would be preffered:
On a side note, the GoReleaser Project is currently actively sponsored by SAP –https://github.com/sponsors/caarlos0#sponsors.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would be fine to switch to go releaser to generate the release notes. Let me revert that back. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| name-template: 'v$RESOLVED_VERSION' | ||
| tag-template: 'v$RESOLVED_VERSION' | ||
| categories: | ||
| - title: '⚠️ Breaking' | ||
| labels: | ||
| - 'breaking' | ||
| - title: '🚀 Features' | ||
| labels: | ||
| - 'feature' | ||
| - 'enhancement' | ||
| - 'api-change' | ||
| - title: '🐛 Bug Fixes' | ||
| labels: | ||
| - 'fix' | ||
| - 'bugfix' | ||
| - 'bug' | ||
| - title: '🧰 Maintenance' | ||
| labels: | ||
| - 'chore' | ||
| - 'dependencies' | ||
| - 'marketing' | ||
| change-template: '- $TITLE @$AUTHOR (#$NUMBER)' | ||
| change-title-escapes: '\<*_&' # You can add # and @ to disable mentions, and add ` to disable code blocks. | ||
| version-resolver: | ||
| major: | ||
| labels: | ||
| - 'major' | ||
| minor: | ||
| labels: | ||
| - 'minor' | ||
| patch: | ||
| labels: | ||
| - 'patch' | ||
| default: patch | ||
| exclude-labels: | ||
| - 'skip-changelog' | ||
| autolabeler: | ||
| - label: 'api-change' | ||
| files: | ||
| - '/api/*' | ||
| - label: 'documentation' | ||
| files: | ||
| - '*.md' | ||
| branch: | ||
| - '/docs{0,1}\/.+/' | ||
| - label: 'bug' | ||
| branch: | ||
| - '/fix\/.+/' | ||
| title: | ||
| - '/fix/i' | ||
| - label: 'enhancement' | ||
| branch: | ||
| - '/feature\/.+/' | ||
| body: | ||
| - '/JIRA-[0-9]{1,4}/' | ||
| - label: 'enhancement' | ||
| branch: | ||
| - '/enh\/.+/' | ||
| - label: 'chore' | ||
| branch: | ||
| - '/chore\/.+/' | ||
| template: | | ||
| ## Changes | ||
| $CHANGES |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| name: Check Codegen | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths-ignore: | ||
| - 'docs/**' | ||
| - '**/*.md' | ||
|
|
||
| jobs: | ||
| check-codegen: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-go@v5 | ||
| with: | ||
| go-version-file: 'go.mod' | ||
| - name: Run make generate | ||
| run: make generate | ||
| - name: Run make docs | ||
| run: make docs | ||
| - name: Run make helm | ||
| run: make helm | ||
| - name: Compare the expected and actual generated/* directories | ||
| run: | | ||
| if [ "$(git diff | wc -l)" -gt "0" ]; then | ||
| echo "Detected uncommitted changes after build. Consider running 'make generate && make docs && make helm'." | ||
| echo "See status below:" | ||
| git diff | ||
| exit 1 | ||
| fi |
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Things we had previously, that we now removed:
Don't we want to keep them? |
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| name: Cleanup caches by a branch | ||
| on: | ||
| pull_request: | ||
| types: | ||
| - closed | ||
|
|
||
| jobs: | ||
| cleanup: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Check out code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Cleanup | ||
| run: | | ||
| gh extension install actions/gh-actions-cache | ||
|
|
||
| REPO=${{ github.repository }} | ||
| BRANCH="refs/pull/${{ github.event.pull_request.number }}/merge" | ||
| echo "Fetching list of cache key" | ||
| cacheKeysForPR=$(gh actions-cache list -R $REPO -B $BRANCH | cut -f 1 ) | ||
| ## Setting this to not fail the workflow while deleting cache keys. | ||
| set +e | ||
| echo "Deleting caches..." | ||
| for cacheKey in $cacheKeysForPR | ||
| do | ||
| gh actions-cache delete $cacheKey -R $REPO -B $BRANCH --confirm | ||
| done | ||
| echo "Done" | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm having a hard time to understand how screenshots would actually be a good way to explain a problem with a k8s operator. I guess this is just the template copied from somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just some dummy template which needs to be adjusted :)