-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Fixes venv pip installation in uv with --seed
#4273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes venv pip installation in uv with --seed
#4273
Conversation
Greptile SummaryAdded the Key changes:
Note: The same Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Documentation
participant UV as uv (Package Manager)
participant VirtualEnv as Virtual Environment
participant Pip
User->>Documentation: Read setup instructions
rect rgb(240, 240, 240)
note right of User: Before fix (broken workflow)
User->>UV: uv venv --python 3.11 env_isaaclab
UV->>VirtualEnv: Create virtual environment
Note over VirtualEnv: No pip installed
User->>Pip: Run pip commands
Pip-->>User: Error: Uses system pip instead
end
rect rgb(220, 255, 220)
note right of User: After fix (working workflow)
User->>UV: uv venv --python 3.11 --seed env_isaaclab
UV->>VirtualEnv: Create virtual environment
UV->>Pip: Install pip in venv
Note over VirtualEnv,Pip: pip properly installed
User->>Pip: Run pip commands
Pip-->>User: Success: Uses venv pip
end
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
docs/source/setup/installation/include/pip_python_virtual_env.rst, line 48-49 (link)style: Check that the same
uv venvcommands indocs/source/setup/quickstart.rst(lines 54 and 64) also have the--seedflag to prevent the same workflow error
1 file reviewed, 1 comment
a80deb5 to
0659e51
Compare
| # create a virtual environment named env_isaaclab with python3.11 | ||
| conda create -n env_isaaclab python=3.11 | ||
| # create a virtual environment named env_isaaclab with python3.11 and pip | ||
| conda create -n env_isaaclab --seed python=3.11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conda does not require --seed
| conda create -n env_isaaclab --seed python=3.11 | |
| conda create -n env_isaaclab python=3.11 |
--seed
| uv venv --python 3.11 --seed env_isaaclab | ||
| # activate the virtual environment | ||
| source env_isaaclab/bin/activate | ||
| # manually install pip via uv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # manually install pip via uv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| uv venv --python 3.11 --seed env_isaaclab | ||
| :: activate the virtual environment | ||
| env_isaaclab\Scripts\activate | ||
| :: manually install pip via uv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| :: manually install pip via uv |
| :: activate the virtual environment | ||
| env_isaaclab\Scripts\activate | ||
| :: manually install pip via uv | ||
| uv pip install pip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| :: activate the virtual environment | ||
| env_isaaclab\Scripts\activate | ||
| :: manually install pip via uv | ||
| uv pip install pip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adds `--seed` in the command for `uv` to install pip. Otherwise subsequent uv workflow uses system default pip which results in errors. - Documentation update - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
Description
Adds
--seedin the command foruvto install pip. Otherwise subsequent uv workflow uses system default pip which results in errors.Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there