Open
Conversation
Collaborator
|
Thanks! Feel free to add the tab completion to this PR. We'll need to make sure that it works with contacts' names with spaces. We should also add the ability to add and remove people from the group. That is pretty integral to the 'group management functionality', if we want to make it part of scli. The same signal-cli's |
Author
|
great thanks, I'll take a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ability to add a new group with existing contacts per ticket #72. I will have a follow up PR for tab completion of contacts name/ number, my plan is to follow this approach from the ticket:
Please let me know if you have any input on this approach.