Support for escaping comment symbols in configuration file.#231
Open
helgihg wants to merge 1 commit intoisamert:developfrom
Open
Support for escaping comment symbols in configuration file.#231helgihg wants to merge 1 commit intoisamert:developfrom
helgihg wants to merge 1 commit intoisamert:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to color the incoming/outgoing messages using the config file instead of command arguments, like this:
But I ran into the problem that the
#symbol which is used to specify colors precisely, conflicted with the same symbol being used to indicate a comment.I thought of changing how colors were handled, i.e. by removing the
#from color definitions, but that would be a software design decision that I felt uncomfortable making.This allows hash symbols in configuration values by escaping them. It shouldn't break existing configurations.