ci: unbreak pkg/lockdown build and remove broken/redundant workflows#10
Closed
israel2606 wants to merge 2 commits into
Closed
ci: unbreak pkg/lockdown build and remove broken/redundant workflows#10israel2606 wants to merge 2 commits into
israel2606 wants to merge 2 commits into
Conversation
Three of four red workflows (golangci-lint, go.yml, go-build.yml) shared one root cause: pkg/lockdown no longer compiled. The lockdown package was refactored after PR #5 branched, and the safety_coverage_test.go added by #5 still referenced the removed API (newSafetyTestCache, the old queryRepoAccessInfo signature, repoAccessCacheEntry.viewerLogin) — a semantic conflict git did not catch on merge. lockdown_test.go already covers the new design, so the obsolete file is removed. Also remove two broken/redundant workflows: - python-package.yml: an empty deprecation stub with no jobs, which is an invalid workflow and always reports failure. - go-build.yml: redundant with go.yml (Build and Test Go Project) and built on Node20-deprecated actions (setup-go@v4, cache@v3). go mod tidy -diff, script/test, and go vet all pass. https://claude.ai/code/session_01W9xh1kJCqtHqBgBAMQikon
Three Spanish-language tracking docs under docs/: - TRABAJO_REALIZADO.md: chronological record of work done - PENDIENTES_DE_RESOLVER.md: in-flight items and known issues - PENDIENTES_DE_EMPEZAR.md: not-yet-started work, with current coverage map https://claude.ai/code/session_01W9xh1kJCqtHqBgBAMQikon
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
maincurrently has four red workflows. Three of them — golangci-lint, go.yml (Build and Test Go Project), and go-build.yml (Go Build and Test) — share a single root cause:pkg/lockdownno longer compiles.The lockdown package was refactored in PR #6, which merged before PR #5. The
safety_coverage_test.gothat #5 added still referenced the old API that #6 removed:This is a semantic conflict git did not catch on merge (the file was new, so there was no textual conflict).
lockdown_test.goalready covers the refactored design, so the obsolete file is removed.Changes
pkg/lockdown/safety_coverage_test.gogolangci-lint,go.yml,go-build.yml(the compile error).github/workflows/python-package.ymljobs:— an invalid workflow that always reports failure.github/workflows/go-build.ymlgo.yml; built on Node20-deprecated actions (setup-go@v4,cache@v3) that break after 2026-06-16No production code changes.
Verification (local)
Note
PR #6's refactor replaced the design that PR #5's tests targeted, so lockdown statement coverage is back to ~79%. Re-adding coverage for the new
RepoAccessCachedesign (REST-based push-access check,viewerLoginFor, etc.) is a worthwhile follow-up but is out of scope here — this PR is strictly about getting CI green.🤖 Generated with Claude Code
Generated by Claude Code