Skip to content

Slider synchronization#34

Merged
olivhoenen merged 9 commits intoiterorganization:developfrom
mfiaudrin-epsyl:feature/slider_synchronization
Mar 9, 2026
Merged

Slider synchronization#34
olivhoenen merged 9 commits intoiterorganization:developfrom
mfiaudrin-epsyl:feature/slider_synchronization

Conversation

@mfiaudrin-epsyl
Copy link
Collaborator

@mfiaudrin-epsyl mfiaudrin-epsyl commented Feb 18, 2026

This feature allows the user to link grids together from the customization component in order to synchronize their common sliders.

@mfiaudrin-epsyl mfiaudrin-epsyl marked this pull request as ready for review February 19, 2026 09:25
@mfiaudrin-epsyl mfiaudrin-epsyl force-pushed the feature/slider_synchronization branch from a8b7541 to f6ef1cb Compare February 26, 2026 10:52
@mfiaudrin-epsyl
Copy link
Collaborator Author

mfiaudrin-epsyl commented Feb 26, 2026

Hello @olivhoenen,

I have fixed the bug you had presented in the last meeting. Now we preserve in all cases the selected plot mode when we go back from customization or metadatas.

The PR is ready to be reviewed

Copy link
Contributor

@olivhoenen olivhoenen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok now

Btw launch-dev.sh script (here and develop) seems broken again: it does not raise the application, do you confirm @mfiaudrin-epsyl @prasad-sawantdesai or is it just me?

Copy link

@deepakmaroo deepakmaroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mfiaudrin-epsyl
Copy link
Collaborator Author

Great, thank you @olivhoenen, @deepakmaroo,
When this PR will be merged into develop, I will rebase PR #45 in order to get the common bugfix and mark it as ready.

Yes I confirm that launch-dev.sh doesn't works since PR #15 (merged), that's why develop and all pull requests rebased on develop have the same problem.

I also find this issue when I was implementing frontend tests in PR #45. So I fixed it in this branch (because at first, I was thinking this problems occured only in this branch). I should have done it in a specific branch to approve and merge it as first. To do it proprely, do you want me to create a new branch, implementing this fix initially in PR #45 or it's ok and we keep the bugfix in PR #45 ?

@olivhoenen
Copy link
Contributor

Fine keeping it in #45

@mfiaudrin-epsyl mfiaudrin-epsyl force-pushed the feature/slider_synchronization branch from 7de7bf8 to 7bf2e1f Compare March 9, 2026 07:30
@olivhoenen olivhoenen merged commit c5c54da into iterorganization:develop Mar 9, 2026
4 checks passed
@mfiaudrin-epsyl mfiaudrin-epsyl deleted the feature/slider_synchronization branch March 18, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants