Skip to content

fix(hdf5): read HDF5_BACKEND_VERSION using actual stored type(#42) #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prasad-sawantdesai wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix(hdf5): read HDF5_BACKEND_VERSION using actual stored type(#42) #43

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4813207
fix(hdf5): read HDF5_BACKEND_VERSION using actual stored type(#42)
prasad-sawantdesai Mar 12, 2026
83a3079
fix the issue while put
prasad-sawantdesai Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 22 additions & 13 deletions src/hdf5/hdf5_utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
#include <iostream>
#include <fstream>
#include <errno.h>
#include <vector>
#include <boost/filesystem.hpp>

using namespace boost::filesystem;
Expand Down Expand Up @@ -75,24 +76,32 @@ int
throw ALBackendException(error_message, LOG);
}

hid_t dtype_id = H5Tcopy (H5T_C_S1);
H5Tset_size(dtype_id, strlen(backend_version_attribute_name));

herr_t tset = H5Tset_cset(dtype_id, H5T_CSET_UTF8);
if (tset < 0) {
char error_message[100];
sprintf(error_message, "Unable to set characters to UTF8 for: %s\n", backend_version_attribute_name);
throw ALBackendException(error_message);
hid_t attr_file_type = H5Aget_type(att_id);
if (attr_file_type < 0) {
H5Aclose(att_id);
char error_message[200];
sprintf(error_message, "Unable to get type of attribute: %s\n", backend_version_attribute_name);
throw ALBackendException(error_message, LOG);
}
size_t attr_size = H5Tget_size(attr_file_type);
H5T_cset_t attr_cset = H5Tget_cset(attr_file_type);
H5Tclose(attr_file_type);

hid_t dtype_id = H5Tcopy(H5T_C_S1);
H5Tset_size(dtype_id, attr_size + 1);
H5Tset_strpad(dtype_id, H5T_STR_NULLTERM);
H5Tset_cset(dtype_id, attr_cset);

char version[10];
herr_t status = H5Aread(att_id, dtype_id, version);
std::vector<char> version(attr_size + 1, '\0');
herr_t status = H5Aread(att_id, dtype_id, version.data());
if (status < 0) {
H5Tclose(dtype_id);
H5Aclose(att_id);
char error_message[200];
sprintf(error_message, "Unable to read attribute: %s\n", backend_version_attribute_name);
throw ALBackendException(error_message, LOG);
}
backend_version = std::string(version);
backend_version = std::string(version.data());
H5Tclose(dtype_id);
H5Aclose(att_id);
} else {
Expand Down Expand Up @@ -344,8 +353,8 @@ void HDF5Utils::writeHeader(DataEntryContext * ctx, hid_t file_id, std::string &

//write version to file
hid_t dataspace_id = H5Screate(H5S_SCALAR);
hid_t dtype_id = H5Tcopy (H5T_C_S1);
H5Tset_size(dtype_id, strlen(backend_version_attribute_name));
hid_t dtype_id = H5Tcopy(H5T_C_S1);
H5Tset_size(dtype_id, backend_version.length() + 1);
herr_t tset = H5Tset_cset(dtype_id, H5T_CSET_UTF8);
if (tset < 0) {
char error_message[200];
Expand Down
Loading