[IMAS-5328] Rebasing the full set of additions requested in IMAS-5328… #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This changes complaining AL-Java compilation issue |
…ade-off agreed with the author of the ticket)
Collaborator
Author
|
Does it work with this lighter version of the IDS ? I think this would satisfy 90% of the needs of the author of the ticket |
Contributor
|
I apologise, missed this updates and notification. |
olivhoenen
requested review from
DavidPCoster,
SimonPinches,
aksinghh,
medvedevsyu,
pankin,
qsthayashi,
simpla-fusion and
yegakjh
as code owners
DavidPCoster
approved these changes
Dec 2, 2025
SimonPinches
reviewed
Dec 2, 2025
Co-authored-by: Simon Pinches <SimonPinches@users.noreply.github.com>
Co-authored-by: Simon Pinches <SimonPinches@users.noreply.github.com>
deepakmaroo
added a commit
to deepakmaroo/IMAS-Java
that referenced
this pull request
Dec 4, 2025
deepakmaroo
added a commit
to deepakmaroo/IMAS-Java
that referenced
this pull request
Dec 4, 2025
olivhoenen
pushed a commit
to iterorganization/IMAS-Java
that referenced
this pull request
Dec 4, 2025
olivhoenen
pushed a commit
to iterorganization/IMAS-Java
that referenced
this pull request
Dec 4, 2025
Collaborator
Author
|
Dear reviewers, the technical issues are solved for this branch, can you please complete your review of this PR ? It's not a draft anymore. Thanks |
SimonPinches
requested changes
Dec 16, 2025
Co-authored-by: Simon Pinches <SimonPinches@users.noreply.github.com>
olivhoenen
approved these changes
Dec 17, 2025
simpla-fusion
approved these changes
Dec 18, 2025
qsthayashi
approved these changes
Dec 18, 2025
medvedevsyu
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… onto develop
Draft PR for the moment, just to test if the AL manages to compile with these extensions
@prasad-sawantdesai
@olivhoenen
📚 Documentation preview 📚: https://imas-data-dictionary--172.org.readthedocs.build/en/172/