[IMAS-3851] Adding profiles_1d/triangularity in the EQUILIBRIUM IDS f… #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or symmetry with the boundary structure
imbeauf
requested review from
DavidPCoster,
SimonPinches,
aksinghh,
medvedevsyu,
olivhoenen,
pankin,
qsthayashi,
simpla-fusion and
yegakjh
as code owners
|
"Upper triangularity w.r.t. magnetic axis" in profiles_1d is not consistent with the definition in the boundary structure. |
Collaborator
Author
Indeed, fixed to simply : "Upper triangularity" |
medvedevsyu
approved these changes
Dec 1, 2025
pankin
approved these changes
Dec 1, 2025
SimonPinches
approved these changes
Dec 2, 2025
olivhoenen
approved these changes
Dec 2, 2025
aksinghh
approved these changes
Dec 3, 2025
simpla-fusion
approved these changes
Dec 4, 2025
qsthayashi
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…or symmetry with the boundary structure
📚 Documentation preview 📚: https://imas-data-dictionary--175.org.readthedocs.build/en/175/