chore(deps-dev): upgrade TypeScript to 6.0.3#668
Merged
Conversation
Bumps [typescript](https://github.com/microsoft/TypeScript) from 5.9.3 to 6.0.3. - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v5.9.3...v6.0.3) --- updated-dependencies: - dependency-name: typescript dependency-version: 4.9.5 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Migrate moduleResolution from deprecated node10 to bundler + commonjs per TypeScript 6 guidance, and type Promise chains in glyphsData for stricter inference under TS 6. Co-authored-by: Cursor <cursoragent@cursor.com>
Integrate cosmiconfig v9, SWC/Jest migration, and regenerate package-lock.json for TypeScript 6.0.3. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Pull request overview
Upgrades the project’s TypeScript toolchain to TS 6.0.3 and adjusts compilation/bundling settings and a couple of promise typings to keep builds and type inference working under TS 6.
Changes:
- Bump
typescriptdevDependency from5.9.3to6.0.3(and lockfile updates). - Update
tsconfig.jsoncompiler options related to module resolution/output. - Add explicit
Promise<GlyphData>typings and set Rollup TS pluginmoduleoverride to keep Rollup output compatible.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tsconfig.json |
Updates module/moduleResolution and explicit strictness toggles for TS 6 transition. |
src/standalone/glyphsData.ts |
Adds explicit Promise/result typings to stabilize inference under TS 6. |
rollup.config.js |
Overrides TS compiler module for the Rollup TypeScript plugin. |
package.json |
Updates typescript to 6.0.3. |
package-lock.json |
Lockfile updates to reflect the TypeScript bump. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Proposed changes
This PR supersedes #611 and brings the following changes:
typescriptfrom5.9.3to6.0.3.tsconfig.jsonfrom deprecatedmoduleResolution: "Node"(node10) tomoduleResolution: "bundler"+module: "commonjs", per the TypeScript 6 migration guide.module: "esnext"in the Rollup TypeScript plugin so bundling stays compatible with@rollup/plugin-typescript.Promise<GlyphData>chains inglyphsData.tsfor stricter inference under TS 6.noImplicitAny: falseandstrictNullChecks: falseexplicitly during the TS 6 transition (same effective strictness as before under node10).Related issue
Supersedes #611 (Dependabot TypeScript bump).
Dependencies added/removed (if applicable)
typescript5.9.3→6.0.3.Testing
How to test
npm test— build, lint, declaration emit, and all 67 Jest tests pass.postbuild(tsc --emitDeclarationOnly) no longer fails with TS5107 onmoduleResolution=node10.Test configuration
Checklist
Made with Cursor