Fix storybook configuration issue preventing it from running locally#1221
Merged
brentswisher merged 1 commit intodevelopfrom Mar 10, 2026
Merged
Fix storybook configuration issue preventing it from running locally#1221brentswisher merged 1 commit intodevelopfrom
brentswisher merged 1 commit intodevelopfrom
Conversation
|
daneah
approved these changes
Mar 10, 2026
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
Closes #1220
How does this change work?
We had added
@vitejs/plugin-reactin theoptimizeDeps > includeblock of the storybook vite config when we updated to Storybook v8.Vite OptimzeDeps is a dev only setting which lists dependencies to pre-bundle.
It looks like
@vitejs/plugin-react 5.xintroduced a dynamic import call in its source tovite/internal. When@vitejs/plugin-reactis listed inoptimizeDeps.include, Vite's pre-bundler attempts to statically analyze and bundle the plugin itself, hitting this unresolvable specifier and crashing.Removing
@vitejs/plugin-reactform theoptimizeDepsconfig resolves this. If I remember correctly, the only reason it was added was that Storybook wasn't rendering locally without it at the time, so I don't see any reason we shouldn't remove it.