Merged
Conversation
3556: Release 4.0.0
no message
no message
Update README.md formatting
Set default for ADMIN_OIDC_ALLOW_HTTP to false
Add ^8.0 version constraint to all symfony/* packages in require and require-dev. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add trailing commas to multiline constructor parameters as required by php-cs-fixer. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Remove all ignoreErrors and set level to max - Add PHPDoc array shapes for config parameters - Add is_string() guards for mixed values from cache and session - Add UserInterface generic to UserProviderInterface - Fix return type annotation on validateClaims() Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add new test classes: - CliLoginTokenAuthenticatorTest - OpenIdConfigurationProviderManagerTest - UserLoginCommandTest - ConfigurationTest - ItkDevOpenIdConnectExtensionTest - TestInvalidArgumentException helper Update existing tests: - Add empty nonce and missing code tests to OpenIdLoginAuthenticatorTest - Add cache exception path tests to CliLoginHelperTest - Add bundle method tests to ItkDevOpenIdConnectBundleTest - Use createStub() instead of createMock() where no expectations are set Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Update phpunit/phpunit constraint from ^11.0 to ^12.0 - Update phpunit.xml.dist schema to 12.5 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Split monolithic pr.yaml into separate workflow files following itk-dev/devops_itkdev-docker template pattern. Use docker compose services instead of shivammathur/setup-php. Add PHP 8.4 and 8.5 containers for testing. Fix Symfony 8 breaking changes in Configuration and test kernel. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This is a library without a committed composer.lock, so composer install fails trying to create one with permission errors inside the docker container. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Run composer update as the host user to allow writing composer.lock in the mounted volume. Subsequent commands can run as the default container user since vendor/ and composer.lock are now writable. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Normalize composer.json version constraints (| to ||). Run all docker compose commands as host user to avoid file permission issues. Add XDEBUG_MODE=coverage for unit test coverage. Remove hardcoded build/ report paths from phpunit.xml.dist. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add prefer-stable and prefer-lowest matrix to unit tests and composer validate jobs. Rename all job names to match the required check names from branch protection rules. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use template-style naming: no custom name on changelog job, consistent format for matrix job names. Update branch protection required checks to match. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add networks, COMPOSE_USER, extra_hosts, and markdownlint/prettier tooling services matching the itkdev-docker template. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace .markdownlint.json with .markdownlint.jsonc, add .markdownlintignore, .prettierrc.yaml, and simplify .php-cs-fixer.dist.php to standard @symfony rules. Remove package.json (markdownlint now via docker). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add COMPOSE_USER env, docker network creation steps, devops header comments. Add markdown.yaml and yaml.yaml workflows. Use composer install instead of update for deterministic CI builds. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove escapestudios/symfony2-coding-standard and kubawerlos/php-cs-fixer-custom-fixers. Rename composer scripts to match itkdev conventions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove redundant {@inheritdoc} tags and superfluous phpdoc param
annotations as required by the standard @symfony php-cs-fixer rules.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add blank lines around headings/lists in CHANGELOG.md, fix long line and heading level in README.md, normalize YAML quoting via prettier. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Provides setup, lint, analyze, test, and test:matrix tasks matching the CI workflow. Includes pr:actions to run all checks locally. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace manual docker compose commands with task-based workflow. Document setup, lint, analyze, test, test:matrix, and pr:actions tasks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
OIDC discovery shipped in Symfony 7.3 and multiple providers are now supported natively. Clarify that Symfony's OIDC support covers bearer token validation only, not the authorization code flow (browser login) that this bundle provides. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Remove lone @param doc on UserLoginCommand constructor (inconsistent) - Remove @codeCoverageIgnore and unreachable is_string guard - Restore cache_pool defaultValue('cache.app') in Configuration - Remove verbose @param array shape on OpenIdConfigurationProviderManager - Remove @var type annotation on ItkDevOpenIdConnectExtension - Revert PHPStan from max to level 8 with targeted ignoreErrors - Remove overly deep testGetContainerExtension and testGetPath tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Each PHP version × dependency set combination gets its own vendor volume, eliminating cross-contamination between lowest/stable runs. A shared composer-cache volume avoids re-downloading packages. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Derive the service name from PHP version and DEPS variables instead of a manual mapping. Cache the resolved composer.lock inside each vendor volume so repeat runs use composer install (no re-resolution). Add test:matrix:reset to wipe volumes and force a fresh resolve. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove redundant isRequired() on cache_pool (already has defaultValue). Replace verbose always/then validation with ifTrue/thenInvalid. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Composer validation/audit is not linting — move it out of the lint aggregate and into pr:actions as a standalone step. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix @var annotation syntax for PHPStan (/* → /**) - Add phpfpm84 and phpfpm85 docker compose services for CI - Fix YAML formatting per prettier Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…rs to prevent them from starting in default dev setup
…HP parameter The global PHP (docker compose exec command) was shadowing the test:run task's PHP parameter, so task test:run always used the global value and the default "8.3" never kicked in. Renaming to PHP_EXEC fixes task test:run and task test:run PHP=8.4 DEPS=lowest.
6896: Symfony 8 support, test coverage, CI restructure
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
========================================
Coverage ? 100.00%
Complexity ? 56
========================================
Files ? 9
Lines ? 248
Branches ? 0
========================================
Hits ? 248
Misses ? 0
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 4.1.0