Skip to content

refactor: move Kategori field to bottom of submission form #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yepzdk merged 1 commit into from
Jun 11, 2026
Merged

refactor: move Kategori field to bottom of submission form #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
- Raised card, input, dropdown and divider borders to a WCAG 1.4.11-compliant `#8c8c8c` (3.36:1 on white, up from ~1.2:1) via the `--border-default`/`--border-subtle` tokens; repointed the structural separator borders that hardcoded `--gray-200`/`--gray-350` at `--border-subtle`
- Fixed muted text contrast: `--text-muted` now `#767676` (4.54:1 on white); the dark-footer bottom links use `--gray-350` (9.48:1 on `#333`) instead of the failing `--gray-600` (3.42:1)
- Added an outline "Skriv et høringssvar" button in the hearing header (hidden on the closed variant) and a centered primary one below the answers list, in addition to the existing one above; all three share a `js-submit-horingssvar` hook wired in `variant.js`
- Added help text "Vælg hvilken kategori dit høringssvar passer til" to the Kategori select, linked via `aria-describedby`
- Added help text "Vælg hvilken kategori dit høringssvar passer til" to the Kategori select, linked via `aria-describedby`, and moved the Kategori field to the bottom of the "Indsend høringssvar" form (after the answer text) in both prototypes
- Added a tip on the closed ("Afsluttet") variant linking down to the statistics section: "Se længere nede hvordan høringssvarene har fordelt sig"
- Submission-form hint and notice text darkened to `--text-secondary` (gray-700, ~7:1) and the hint de-italicised for readability at the small size; the notice info icon now follows the text colour (`currentColor`) instead of the near-invisible `--gray-400`
- Reframed the per-answer "synes om" like as an agreement vote: handshake icon (`fa-regular fa-handshake`) and the text "{antal} er enig(e)" (singular-aware), with the sort option renamed "Flest enige". Applied to both cards and the detail modal across the Vosnæs and Uniparken prototypes (shared JS); the underlying `likes` data field is unchanged
Expand Down
22 changes: 11 additions & 11 deletions docs/public/projects/deltag-aarhus/mocks/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,17 +671,6 @@ <h2 class="modal__title" id="submission-modal-title">Indsend høringssvar</h2>
</div>
<div class="modal__body">
<form class="submission-form" id="submission-form">
<div class="submission-form__field">
<label for="submission-category" class="submission-form__label">Kategori</label>
<select id="submission-category" class="submission-form__select" aria-describedby="submission-category-hint" required>
<option value="">Vælg kategori...</option>
<option value="miljoe">Miljø/Natur</option>
<option value="stoej">Støj/Sundhed</option>
<option value="landskab">Landskab/Visuel</option>
<option value="proces">Proces/Andet</option>
</select>
<span class="submission-form__hint" id="submission-category-hint">Vælg hvilken kategori dit høringssvar passer til</span>
</div>
<div class="submission-form__field">
<label for="submission-name" class="submission-form__label">Dit navn</label>
<input type="text" id="submission-name" class="submission-form__input" value="Maria Jensen" readonly>
Expand All @@ -695,6 +684,17 @@ <h2 class="modal__title" id="submission-modal-title">Indsend høringssvar</h2>
<label for="submission-body" class="submission-form__label">Dit høringssvar</label>
<textarea id="submission-body" class="submission-form__textarea" rows="8" required placeholder="Beskriv dine synspunkter, bekymringer eller forslag vedrørende planen..."></textarea>
</div>
<div class="submission-form__field">
<label for="submission-category" class="submission-form__label">Kategori</label>
<select id="submission-category" class="submission-form__select" aria-describedby="submission-category-hint" required>
<option value="">Vælg kategori...</option>
<option value="miljoe">Miljø/Natur</option>
<option value="stoej">Støj/Sundhed</option>
<option value="landskab">Landskab/Visuel</option>
<option value="proces">Proces/Andet</option>
</select>
<span class="submission-form__hint" id="submission-category-hint">Vælg hvilken kategori dit høringssvar passer til</span>
</div>
<div class="submission-form__notice">
<i class="fa-solid fa-circle-info" aria-hidden="true"></i>
<p>Alle høringssvar er omfattet af offentlighedsloven. Dit navn og høringssvar vil blive offentliggjort i forbindelse med byrådets politiske behandling.</p>
Expand Down
20 changes: 10 additions & 10 deletions docs/public/projects/deltag-aarhus/mocks/uniparken/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,16 +660,6 @@ <h2 class="modal__title" id="submission-modal-title">Indsend høringssvar</h2>
</div>
<div class="modal__body">
<form class="submission-form" id="submission-form">
<div class="submission-form__field">
<label for="submission-category" class="submission-form__label">Kategori</label>
<select id="submission-category" class="submission-form__select" required>
<option value="">Vælg kategori...</option>
<option value="miljoe">Miljø/Natur</option>
<option value="stoej">Støj/Sundhed</option>
<option value="landskab">Landskab/Visuel</option>
<option value="proces">Proces/Andet</option>
</select>
</div>
<div class="submission-form__field">
<label for="submission-name" class="submission-form__label">Dit navn</label>
<input type="text" id="submission-name" class="submission-form__input" value="Marie Holm" readonly>
Expand All @@ -683,6 +673,16 @@ <h2 class="modal__title" id="submission-modal-title">Indsend høringssvar</h2>
<label for="submission-body" class="submission-form__label">Dit høringssvar</label>
<textarea id="submission-body" class="submission-form__textarea" rows="8" required placeholder="Beskriv dine synspunkter, bekymringer eller forslag vedrørende planen..."></textarea>
</div>
<div class="submission-form__field">
<label for="submission-category" class="submission-form__label">Kategori</label>
<select id="submission-category" class="submission-form__select" required>
<option value="">Vælg kategori...</option>
<option value="miljoe">Miljø/Natur</option>
<option value="stoej">Støj/Sundhed</option>
<option value="landskab">Landskab/Visuel</option>
<option value="proces">Proces/Andet</option>
</select>
</div>
<div class="submission-form__notice">
<i class="fa-solid fa-circle-info" aria-hidden="true"></i>
<p>Alle høringssvar er omfattet af offentlighedsloven. Dit navn og høringssvar vil blive offentliggjort i forbindelse med byrådets politiske behandling.</p>
Expand Down
Loading