multi_livechat: change mail.channel.partner to mail.channel.member#461
Open
stanleykao72 wants to merge 3 commits intoitpp-labs:16.0from
Open
multi_livechat: change mail.channel.partner to mail.channel.member#461stanleykao72 wants to merge 3 commits intoitpp-labs:16.0from
stanleykao72 wants to merge 3 commits intoitpp-labs:16.0from
Conversation
stanleykao72
commented
Jul 13, 2023
stanleykao72
commented
- mail.channel: the function _prepare_multi_livechat_channel_vals doesn't return public and group_public_id field when create mail.channel
- model mail.channel.partner change to mail.channel.member
yelizariev
reviewed
Jul 13, 2023
Comment on lines
+24
to
+30
| "public": "groups", | ||
| "group_public_id": self.env.ref("base.group_user").id, | ||
| # "public": "groups", # V16 dropout public field | ||
| "group_public_id": False, # V16 checks contrains with group_public_id self.env.ref("base.group_user").id, |
Collaborator
There was a problem hiding this comment.
Field public is removed in v16 -> ok
Field group_public_id is computed in v16 with readonly=False. Maybe just remove the field from result?
Author
There was a problem hiding this comment.
I remove Field group_public_id, and it's working after I tested it.
| for r in self: | ||
| channel_partner = self.env["mail.channel.partner"].search( | ||
| # V16 change mail.channel.partner to mail.channel.member | ||
| channel_partner = self.env["mail.channel.member"].search( |
yelizariev
reviewed
Jul 14, 2023
Comment on lines
+3
to
+8
| from odoo import api, fields, models | ||
| from odoo import api, fields, models, _ | ||
| from odoo.exceptions import UserError, ValidationError | ||
|
|
||
| import logging | ||
|
|
||
| _logger = logging.getLogger(__name__) |
Collaborator
There was a problem hiding this comment.
New imports are not used...
Author
There was a problem hiding this comment.
I removed not used imports
yelizariev
approved these changes
Jul 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.