Fetch fortnum and link it into neo_rt#45
Draft
krystophny wants to merge 4 commits into
Draft
Conversation
Wire the fortnum numerical-core library via CMake FetchContent (git@github.com:lazy-fortran/fortnum.git, pinned to a7faa3c) guarded by if(NOT TARGET fortnum) so a parent build that already provides the target is reused. Link the static library into neo_rt; its module directory is exported PUBLIC, so neo_rt and the diagnostics library that links neo_rt both see the fortnum modules. This commit adds the dependency without changing any solver call site; the existing DVODE path is untouched and still in use. Subsequent commits move the orbit integrations onto the fortnum ODE solver and then drop DVODE.
This was referenced Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge order
This PR is part of the fortnum ODE migration stack. Each PR is now based on
mainindividually, but they must be merged in this sequence:Because all three are based on
main, each later PR's diff is currentlycumulative (it contains its predecessors' changes). Merge in the order above:
once a predecessor merges into
main, the next PR's diff shrinks to its ownincrement.
Base of the NEO-RT migration off the external DVODE solver onto fortnum.
Declares fortnum via FetchContent pinned at a7faa3c and links it into the
neo_rt target. No source behaviour changes here; this only makes the
fortnum ODE modules available to the later commits in the stack.
Stack:
Verification
Configured and built on top of the full stack; see the head PR for the
combined build and test output. This PR alone adds the dependency wiring.
Note: fortnum pin updated to current main (92de6e9) after a fortnum history rewrite; old shas no longer resolve.