Allow libneo-gate dispatch (libneo_ref) in CI#48
Merged
Conversation
The libneo reverse-dependency gate dispatches this workflow (report-only) with -f libneo_ref to fast-gate a candidate libneo. Skip the slow golden-record pytest on workflow_dispatch and run only make ctest; the golden suite stays on NEO-RT's own push/PR runs. LIBNEO_REF already propagates the candidate ref through the NEO-2 dependency.
Remove $ENV{<DEP>_REF} read from find_or_fetch: cmake cache variable
-DLIBNEO_REF=<ref> is the only override path. An LIBNEO_REF set in the
developer's shell can no longer silently alter which libneo ref is fetched.
Makefile unexports LIBNEO_REF so make itself does not import it from the
environment, and forwards only an explicit command-line value as
-DLIBNEO_REF=$(LIBNEO_REF) to cmake.
Workflow removes the top-level env: LIBNEO_REF block and passes the
dispatch input explicitly: make ... LIBNEO_REF=${{ inputs.libneo_ref }}.
README documents -DLIBNEO_REF=<ref> / make LIBNEO_REF=<ref>.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes NEO-RT's side of libneo's per-PR reverse-dependency gate (report-only downstream).
The gate dispatches NEO-RT's
test.ymlwith-f libneo_ref=<sha>and expects only the fast tests.test.ymlalready accepts thelibneo_refworkflow_dispatch input and setsLIBNEO_REFfrom it;LIBNEO_REFpropagates through the NEO-2 dependency to the transitive libneo fetch (cmake/Util.cmakefind_or_fetchresolves<DEP>_REFto the FetchContentGIT_TAG, validated against the remote). In the default standalone build NEO-RT does not compile libneo directly, which is why the gate keeps NEO-RT report-only; the env var is wired so the candidate ref reaches libneo once NEO-2 is built.make ctesttier and skip the slow golden-record pytest. The golden suite stays on NEO-RT's own push/PR runs. Push/PR behavior is unchanged.Tracking itpplasma/code#55, gated by itpplasma/libneo#278.