Fix golden-record odeint path after the src/odeint/ move#279
Merged
Conversation
odeint moved to src/odeint/odeint_allroutines.f90 before v2026.04.13, but fetch_golden_record.sh still read the old top-level path from the latest tag, which broke build_test_golden_record_odeint on main (surfaced here as the first main.yml run since the move). Read the current path instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
build_test_golden_record_odeintjob onmainwas red.fetch_golden_record.shread
src/odeint_allroutines.f90from the latest tag, but odeint moved tosrc/odeint/odeint_allroutines.f90before v2026.04.13. The old top-level path isgone from the tag, so
git show "$LATEST_TAG:src/odeint_allroutines.f90"produced anempty golden file and the regression comparison broke. This was the first
main.ymlrun since the move surfaced it.
One-line fix: read the post-move path. v2026.04.13 contains
src/odeint/odeint_allroutines.f90, and the module names still match the script'sseds, so the golden-record comparison keeps doing its job.
Split out of #278 so it can merge first and unbreak
mainindependently of therelease-gate change.
Verification
Failing before, on
main(golden file empty, comparison fails):Passing after (post-move path exists in the tag):
The identical commit on #278 turned
build_test_golden_record_odeintgreen(full CI: build+test, Sphinx docs, dashboard, Pages deploy). CI on this branch
is running.