Add Boozer refcoords detection coverage#284
Open
krystophny wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-contained regression coverage for refcoords file detection. Boozer chartmaps stay classified as chartmaps, and the detector no longer depends on external setup fixtures for this test.
Verification
Test fails on main
ctest -R test_refcoords_file_detection --output-on-failure Test project /home/ert/code/libneo/build Start 50: test_refcoords_file_detection 1/1 Test #50: test_refcoords_file_detection ....***Failed Error regular expression found in output. Regex=[STOP] 0.12 sec FAIL: detect_refcoords_file_type(chartmap.nc): open failed: No such file or directory FAILED: 1 error(s) detected in refcoords file detection ERROR STOP 1Test passes after fix
ctest -R test_refcoords_file_detection --output-on-failure Test project /home/ert/code/libneo/build Start 50: test_refcoords_file_detection 1/1 Test #50: test_refcoords_file_detection .... Passed 0.08 sec 100% tests passed, 0 tests failed out of 1