Open
Conversation
stapelberg
requested changes
Nov 10, 2021
Collaborator
stapelberg
left a comment
stapelberg
left a comment
There was a problem hiding this comment.
Thanks for your PR!
Could you add a test please, too, and rebase this PR on top of the current branch?
| OpContext: fuseops.OpContext{Pid: inMsg.Header().Pid}, | ||
| Parent: fuseops.InodeID(hdr.Nodeid), | ||
| Name: string(buf[:n-1]), | ||
| OpContext: fuseops.OpContext{ |
Collaborator
There was a problem hiding this comment.
Instead of repeating this struct initialization over and over again, could you factor it out into a opContext(hdr *fusekernel.InHeader) OpContext helper function?
| // macFuse 4.2.1 workaround: the kernel implementation is buggy. | ||
| // It call OpRename with the data type of OpRename2. The workaround consists | ||
| // in skipping the first 8 bytes of names (which are zeroes). | ||
|
|
Contributor
There was a problem hiding this comment.
This workaround was probably already merged in my PR #107 %)
| DisableWritebackCaching bool | ||
|
|
||
| // Enable Posix file locking | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR includes: