Fix release workflow: fetch mozjs, build under packages/native#6
Merged
Conversation
The release workflow has been broken since the project restructure: it ran zig build at repo root, but the build now lives under packages/native and needs libmozjs.dll.a fetched from the artifacts branch (same pattern as CI). Also drops the missing INSTALL.txt copy, includes mozjs.dll in the package (required at runtime), and updates DLL paths to packages/native/zig-out/bin. Mirrors .github/workflows/ci.yml's mozjs fetch + build steps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release workflow has been broken since the project restructure — it ran `zig build` at repo root, but the native build now lives under `packages/native/` and needs `libmozjs.dll.a` fetched from the artifacts branch (same as CI). v0.2.0 shipped a 331KB zip — likely without the DLL.
This mirrors the `.github/workflows/ci.yml` mozjs fetch + working-directory pattern, drops the missing `INSTALL.txt` copy, includes `mozjs.dll` in the package (required at runtime), and updates DLL paths to `packages/native/zig-out/bin/`.
Needed before tagging v0.3.0.
Test plan