Fix panic with modular-bitfield on nightly#355
Open
cj-matti-niemenmaa wants to merge 1 commit intojam1garner:masterfrom
Open
Fix panic with modular-bitfield on nightly#355cj-matti-niemenmaa wants to merge 1 commit intojam1garner:masterfrom
cj-matti-niemenmaa wants to merge 1 commit intojam1garner:masterfrom
Conversation
Only seen on nightly because `backtrace/mod.rs` only provides non-zero lines and columns with `#[cfg(all(feature = "verbose-backtrace", nightly, proc_macro))]`. Simply skip the highlighting if the span spans multiple lines, similarly to how multi-line spans are already not supported by `Visitor::visit_lit` below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only seen on nightly because
backtrace/mod.rsonly provides non-zero lines and columns with#[cfg(all(feature = "verbose-backtrace", nightly, proc_macro))].Simply skip the highlighting if the span spans multiple lines, similarly to how multi-line spans are already not supported by
Visitor::visit_litbelow.Fixes #354.