add missing examples to tests#320
Closed
Rykath wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
So some examples seem to be actually broken and need to be looked into. A number of them also don't have meson scripts, but work when called with I assume the |
Owner
|
Thanks for doing this! Indeed, quip-regression can be left out as it has its own separate CI workflow as it's quite big and slow |
'quip_regression' left out as it has it's own workflow
3 tasks
krystophny
added a commit
to itpplasma/f90wrap
that referenced
this pull request
Dec 15, 2025
The errorbinding example was added to the test suite in PR jameskermode#320 but was missing the required tests.py and tests_pkg.py files, causing CI to fail.
Contributor
|
Fixed in stacked PRs starting with #322 |
krystophny
added a commit
to itpplasma/f90wrap
that referenced
this pull request
Dec 16, 2025
The errorbinding example was added to the test suite in PR jameskermode#320 but was missing the required tests.py and tests_pkg.py files, causing CI to fail.
Owner
|
I believe this PR can be closed in favour of the others from @krystophny, is that correct? |
krystophny
added a commit
to itpplasma/f90wrap
that referenced
this pull request
Dec 18, 2025
The errorbinding example was added to the test suite in PR jameskermode#320 but was missing the required tests.py and tests_pkg.py files, causing CI to fail.
Contributor
I think so, I activated all examples in the subsequent PRs with fixes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #308, some of the examples are not tested. I.e. they are not included in
CmakeLists.txt&Makefile. This PR sorts and adds all available examples into the list.Newly added tests:
callback_print_function_issue93-undefined symbol: pyfunc_print_default_i8-Segmentation faultderived-type-aliasesderivedtypes_procedureerrorbindingf2py_string_input-No rule to make target 'Makefile.meson'fixed_1D_derived_type_array_argumentissue261_array_shapes-No rule to make target 'Makefile.meson'issue299_directc_nested_functions-No rule to make target 'Makefile.meson'issue301_complex_types-No rule to make target 'Makefile.meson'issue302_pointer_warning-No rule to make target 'Makefile.meson'issue41_abstract_classes-AttributeError: 'myclass_t' object has no attribute 'get_value'keyword_renaming_issue160name_collisionrecursive_type-Error: Derived type ‘node’ at (1) has not been declaredrecursive_type_arraysignature_vs_backendsubroutine_argsquip_regressionwas not added to the tests as it has it's own workflow.