Fixed issue #12 (minSize bug)#40
Open
vpalos wants to merge 1 commit intojamesssooi:masterfrom
Open
Conversation
mullema
added a commit
to mullema/Croppr.js
that referenced
this pull request
Sep 9, 2019
|
@jamesssooi Could you merge and release this please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a side-note, I didn't push the compiled code as I don't think the
distfolder should be committed anyway. I would advise to remove it from the git repo entirely as it only complicates things. Just leave it to the user to runnpm install && npm run dist, clean and simple. Thanks!