Make <img> in 1-Index-html translatable #1052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ann0see
requested changes
Sep 30, 2024
This reverts commit 5a2cd47.
pljones
reviewed
Oct 1, 2024
pljones
approved these changes
Oct 1, 2024
ann0see
reviewed
Oct 2, 2024
Member
ann0see
left a comment
ann0see
left a comment
There was a problem hiding this comment.
It seems hacky to me, but well...
ann0see
approved these changes
Dec 13, 2024
Contributor
|
Merging tools (or anything not translatable on Weblate is fine without locking Weblate). |
Member
Author
|
Yeah, originally this PR contained a change to index.md that was later removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
This adds an option to the po4a script to make the content of the
<img>tag translatable - it was being skipped by po4a and made it impossible to show localised screenshots of the main mixer window on the homepage. It also makes it possible to easily add an arbitrary number of options in future if needed.Context: Fixes an issue? Related issues
This problem was pointed out by @henkdegroot on Discord.
Status of this Pull Request
Tested and working
What is missing until this pull request can be merged?
Any Weblate PRs have to be merged first.
Does this need translation?
NO.
Checklist