refactor: consolidate to single BitcoinKernel package with clean namespace layout#11
Merged
refactor: consolidate to single BitcoinKernel package with clean namespace layout#11
Conversation
…nternal visibility Make NativeMethods, all delegate types, and all P/Invoke structs internal in BitcoinKernel.Interop so they are not part of the public API surface. Public enums (ChainType, ScriptVerifyStatus, ScriptVerificationFlags, etc.) remain public as they appear in the Core public API.
- Delete src/BitcoinKernel/ (KernelLibrary fluent builder) and its tests - Rename BitcoinKernel.Core project/namespaces to BitcoinKernel - Rewrite examples to use the managed API directly
Eliminates the latent name collision between the Chain class (previously in BitcoinKernel.Abstractions) and the BitcoinKernel.Chain namespace. Users can now access Chain via a single import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove facade: deleted
BitcoinKernelfluent builder (KernelLibrary) and its integration tests; consumers now use the managed API directlyRename
BitcoinKernel.CoretoBitcoinKernel: single package, consistent with the NuGet idNamespace clean-up:
BitcoinKernel.AbstractionstoBitcoinKernel.Primatives;Chainclass moved intoBitcoinKernel.Chain;LoggingConnectionplaced inBitcoinKernelVersion bump: 0.1.2 to 0.2.0