Merged
Conversation
|
|
jeaye
approved these changes
Jan 31, 2026
Member
jeaye
left a comment
jeaye
left a comment
There was a problem hiding this comment.
Looks great to me. Waiting for Emma's review and then we're good to merge.
E-A-Griffin
approved these changes
Jan 31, 2026
Collaborator
E-A-Griffin
left a comment
E-A-Griffin
left a comment
There was a problem hiding this comment.
Mostly looks good! There's technically a variadic arg variant so it would be nice to have one test for that (vector a b c d e f & args)
Contributor
Author
I added 2 tests line 47. Do you think it is ok ? |
E-A-Griffin
approved these changes
Feb 1, 2026
Collaborator
E-A-Griffin
left a comment
E-A-Griffin
left a comment
There was a problem hiding this comment.
Perfect! Thanks so much
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #564