Merged
Conversation
Im still a clojure beginner so sorry if there are any obvious mistakes. The NaN ordering stuff caught me off guard. I made `=-or-NaN?` to organize `are` testing. It was much messier with `=`. The `numeric ordering` tests were more or less yoinked from `min.cljc`.
|
|
Contributor
Author
|
oof clr failed cause I should probably reimplement them. I was messing around with |
Contributor
Author
|
looks like basilisp test cases didnt pass. let me fix that |
Contributor
Author
|
this closes #365 |
Member
This needs to go in the PR description, rather than be a comment. You can edit the description at any time. |
Contributor
Author
|
thanks for pointing out. fixed |
jeaye
approved these changes
Feb 26, 2026
Member
jeaye
left a comment
jeaye
left a comment
There was a problem hiding this comment.
Thank you! Sorry about the delay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm still a clojure beginner so let me know if theres any obvious issues
NaNordering was surprising. Its because(<= ##NaN 1)and(<= 1 ##NaN)are both false.I made
=-or-NaN?to help witharetesting. With only=, it got messy.this closes #365