Skip to content

More expressive Error stack : ComponentNotFoundError #68

Closed
piercus wants to merge 6 commits into
jaredhanson:masterfrom
piercus:master
Closed

More expressive Error stack : ComponentNotFoundError #68
piercus wants to merge 6 commits into
jaredhanson:masterfrom
piercus:master

Conversation

@piercus

@piercus piercus commented Oct 26, 2017

Copy link
Copy Markdown

Hello,

Thank you for this lib.

before

        » An unexpected error was caught: Error 
      at /.../electrolyte/lib/container.js:187:18 

after

        » An unexpected error was caught: ComponentNotFoundError: Unable to create component 'parent' required by 'child' 
      at ComponentNotFoundError (/.../electrolyte/lib/errors/componentnotfound.js:7:20) 

I've followed https://stackoverflow.com/questions/783818/how-do-i-create-a-custom-error-in-javascript

@coveralls

coveralls commented Oct 26, 2017

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.5%) to 92.982% when pulling ae3f0e7 on piercus:master into d6af75b on jaredhanson:master.

@coveralls

coveralls commented Nov 3, 2017

Copy link
Copy Markdown

Coverage Status

Coverage increased (+2.0%) to 95.517% when pulling 475581b on piercus:master into d6af75b on jaredhanson:master.

@piercus piercus changed the title ComponentNotFoundError more expressives More expressive Error stack : ComponentNotFoundError Nov 3, 2017
@coveralls

coveralls commented Nov 8, 2017

Copy link
Copy Markdown

Coverage Status

Coverage increased (+2.0%) to 95.517% when pulling 7a596af on piercus:master into d6af75b on jaredhanson:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+2.0%) to 95.517% when pulling 7a596af on piercus:master into d6af75b on jaredhanson:master.

3 similar comments
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+2.0%) to 95.517% when pulling 7a596af on piercus:master into d6af75b on jaredhanson:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+2.0%) to 95.517% when pulling 7a596af on piercus:master into d6af75b on jaredhanson:master.

@coveralls

coveralls commented Nov 8, 2017

Copy link
Copy Markdown

Coverage Status

Coverage increased (+2.0%) to 95.517% when pulling 7a596af on piercus:master into d6af75b on jaredhanson:master.

@piercus

piercus commented Jan 12, 2018

Copy link
Copy Markdown
Author

replace by #71

@piercus piercus closed this Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants