Pull request for issue #5050 #5334
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the ntfy documentation and Dockerfile to provide clearer instructions for you when trying to configure iOS push notifications (APNS). README.md: - I added a new "iOS Notifications (APNS Setup)" section. - I explained the necessity of APNS configuration via `server.yml`. - I mentioned Apple Developer account requirements (auth key, Key ID, Team ID). - I linked to the official ntfy documentation for detailed APNS setup. - I provided an example of mounting `server.yml` in `docker run`. Dockerfile: - I added a `VOLUME /etc/ntfy` instruction to indicate the standard configuration directory. - I included comments guiding you to the README and official docs for `server.yml`. - I added commented-out examples of potential environment variables for APNS, with a strong recommendation to verify them against ntfy's official documentation. These changes aim to help you understand that APNS configuration is external to this Docker packaging but provide better hooks and guidance for it.
|
Review changes with |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5050