Skip to content

Added tests for tasks 33-1036 #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
javadev merged 3 commits into from
Nov 27, 2025
Merged

Added tests for tasks 33-1036 #908

javadev merged 3 commits into from
Nov 27, 2025

Conversation

@ThanhNIT
Copy link
Contributor

@ThanhNIT ThanhNIT commented Nov 27, 2025

No description provided.

@javadev
Copy link
Owner

javadev commented Nov 27, 2025

SolutionTest > isRationalEqual6() FAILED
java.lang.AssertionError at SolutionTest.kt:35

@javadev
Copy link
Owner

javadev commented Nov 27, 2025

SolutionTest > isRationalEqual9() FAILED

@javadev
Copy link
Owner

javadev commented Nov 27, 2025

@ThanhNIT Why tests failed, may be we need recreate a solution from java?

@ThanhNIT
Copy link
Contributor Author

ThanhNIT commented Nov 27, 2025

@ThanhNIT Why tests failed, may be we need recreate a solution from java?

let me check

@javadev
Copy link
Owner

javadev commented Nov 27, 2025

SolutionTest > isRationalEqual9() FAILED
java.lang.ArrayIndexOutOfBoundsException at SolutionTest.kt:50

@javadev
Copy link
Owner

javadev commented Nov 27, 2025

You may try to convert java solution to kotlin with help of gemini

@ThanhNIT
Copy link
Contributor Author

ThanhNIT commented Nov 27, 2025 •
edited
Loading

I have converted from java and passed all test cases on leetcode

@javadev
Copy link
Owner

javadev commented Nov 27, 2025 •
edited
Loading

I have converted from java and passed all test cases on leetcode

Ok, let's modify tests for worked solution

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 27, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@javadev
Copy link
Owner

javadev commented Nov 27, 2025

✅

@javadev javadev merged commit 68f38a5 into javadev:main Nov 27, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ThanhNIT @javadev