This repository was archived by the owner on Apr 25, 2025. It is now read-only.
Use generated thumbnail image instead of original image file#70
Open
zekefarwell wants to merge 1 commit intojayelkaake:masterfrom
Open
Use generated thumbnail image instead of original image file#70zekefarwell wants to merge 1 commit intojayelkaake:masterfrom
zekefarwell wants to merge 1 commit intojayelkaake:masterfrom
Conversation
rjocoleman
added a commit
to icecubenz-open-mage/enhancedgrid
that referenced
this pull request
Jan 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the image url used in the product grid to be a generated file resized to the dimensions of the config settings (enhancedgrid/images/width and enhancedgrid/images/height). This helps thumbnails load much more quickly if the originals are large. It also constrains thumbnails to a square helping to maintain the grid layout when non-square images get uploaded as shown in the screenshots below.
Before:
After:
